Skip to content

fix: tolerate punctuation in voice activation finish phrase - #1219

Closed
HKLHaoBin wants to merge 9 commits into
Open-Less:betafrom
HKLHaoBin:feat/issue-1003-voice-activation
Closed

HKLHaoBin wants to merge 9 commits into
Open-Less:betafrom
HKLHaoBin:feat/issue-1003-voice-activation

Conversation

@HKLHaoBin

@HKLHaoBin HKLHaoBin commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Fix voice activation finish commands when local ASR inserts punctuation inside the phrase, such as 完成,语音录入。.
  • Apply the same NFKC-aware punctuation handling to transcript cleanup so the finish phrase is removed without dropping punctuation from the spoken body.
  • Add regression coverage for Chinese punctuation, full-width punctuation, whitespace, and suffix-only matching.

Refs #1003

Why retain the diagnostic probes?

There is no further tester evidence confirming whether the intermittent recognition crash has been resolved or simply has not reproduced. We therefore retain the existing privacy-safe P1–P6 diagnostic probes rather than treating the absence of a new report as proof of a fix. If the issue recurs, these lifecycle and timing records, together with the matching Windows EXE/PDB, will provide evidence for further investigation. The probes do not record audio or transcript content. They should be removed only after sufficient real-device verification; passing CI alone does not establish that the intermittent crash is fixed.

Beta synchronization

Merged beta at 8e8b3dbd and resolved the overlapping voice-activation conflicts, preserving the newer implementation, regression tests, diagnostic probes, and Windows symbols already merged via #1240. Application source now matches beta; the only remaining branch-only difference is the pre-existing Android workflow repository-metadata setting. This synchronization does not introduce another behavioral fix or claim that all of #1003 is resolved.

Verification

Current commit: e3b5c6ba8c8eaa60b29b47197f04dbcf753df711.

  • git diff --check and staged whitespace checks passed; no unresolved merge conflicts remain.
  • All compilation, tests, and packaging run in GitHub Actions, not locally.
  • PR CI: passed, including Windows, macOS, Linux, Android, Harmony, and UI motion. MSRV is skipped by the workflow's existing condition.
  • Native capsule checks: passed on Windows and macOS.
  • Branch CI: Windows, Linux, Android, Harmony, and UI motion passed. macOS initially did not acquire a hosted runner (runner_id=0, no steps); GitHub reports macOS ARM capacity constraints. The single targeted retry also ended without acquiring a runner (runner_id=0, no steps), with the same capacity annotations. The branch workflow therefore ended in failure due to unavailable hosted capacity, not an executed test failure; it has not passed as a whole. No further automatic retries are queued.
  • Desktop builds: Windows and macOS Intel jobs, including artifact uploads and post-build steps, passed. macOS ARM initially did not acquire a hosted runner and was cancelled with the same capacity annotation; the single targeted ARM retry also ended without a runner (runner_id=0, no steps), with the same capacity annotations. The overall workflow ended in failure; macOS ARM packaging remains unverified. No further automatic retries are queued.
    • Windows x64 test artifact, retaining matching EXE/PDB. GitHub artifact metadata confirms the current commit and reports ZIP digest sha256:891f00384ee41962948aa54d29e8b817beee9301ec7292ae0590e7908961e4af.
    • macOS Intel artifact.
  • Android arm64 build: passed; release APK artifact.

The PR remains a draft for the author to mark ready after verification. No claim is made that the intermittent crash has passed real-device verification.

🤖 Generated with Claude Code

HKLHaoBin and others added 8 commits September 16, 2026 16:53
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…-activation

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

# Conflicts:
#	.github/workflows/android-apk.yml
#	openless-all/app/package-lock.json
#	openless-all/app/package.json
#	openless-all/app/src-tauri/Cargo.lock
#	openless-all/app/src-tauri/Cargo.toml
#	openless-all/app/src-tauri/tauri.conf.json
…t/issue-1003-voice-activation

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

# Conflicts:
#	openless-all/app/crates/openless-core/src/cloud_sync_e2ee_documents/registry.rs
#	openless-all/app/src-tauri/src/core_adapters.rs
#	openless-all/app/src-tauri/src/recorder.rs
#	openless-all/app/src/components/SettingsModal.tsx
#	openless-all/app/src/i18n/zh-CN.ts
#	openless-all/app/src/lib/ipc/mock-data.ts
#	openless-all/app/src/lib/types.ts
#	openless-all/app/src/pages/settings/RecordingInputSection.tsx
#	openless-all/app/src/pages/settings/tabs.tsx
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@HKLHaoBin
HKLHaoBin marked this pull request as draft October 17, 2026 15:59
@H-Chris233 H-Chris233 added area:recording Recording area area:voice Voice area bug Something isn't working enhancement New feature or request large-change Large or risky change needs-review Needs review P2 Medium priority labels Oct 20, 2026
Retain the newer voice activation implementation, punctuation regression tests, privacy-safe P1-P6 diagnostics, and Windows symbols already merged through Open-Less#1240. Resolve overlapping feature conflicts without reverting upstream fixes.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@HKLHaoBin
HKLHaoBin marked this pull request as ready for review October 21, 2026 16:20
@HKLHaoBin

Copy link
Copy Markdown
Collaborator Author

关闭此 PR:相关语音唤醒实现、标点容错修复及 P1–P6 诊断埋点已通过 #1240 合入 beta。同步 beta 后,本 PR 不再包含额外的应用代码变更,仅剩一行 Android 工作流仓库元数据差异,不再单独合并。

现有诊断埋点继续保留在 beta 中。尚未收到进一步问题反馈或暂未复现,不代表偶发崩溃已经完成设备验收;保留埋点便于再次发生时继续排查。本次关闭的是重复 PR,不表示 #1003 的所有问题均已解决,也不关闭该 issue。

@HKLHaoBin HKLHaoBin closed this Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:recording Recording area area:voice Voice area bug Something isn't working enhancement New feature or request large-change Large or risky change needs-review Needs review P2 Medium priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants